Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm/sys_overlay Improvements #6102

Merged
merged 1 commit into from Jul 28, 2019
Merged

vm/sys_overlay Improvements #6102

merged 1 commit into from Jul 28, 2019

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Jun 17, 2019 •
edited

  • Implement sys_overlay_load_module_by_fd.
  • Implement special segment allocation when ppc_seg flag is specified.

@elad335 elad335 force-pushed the vm-overlay branch 2 times, most recently from b2617fb to 1c311fd Compare June 17, 2019 10:37
@kamer1337
Copy link

kamer1337 commented Jun 17, 2019 •
edited

when i try to start Tony hawks proving ground and tony hawks project 8 and skate i get this error

F LDR: class std::runtime_error thrown: falloc() failed (addr=0x10000000, memsz=0x6caea)

@elad335
Copy link
Contributor Author

elad335 commented Jun 17, 2019

Log please.

@kamer1337
Copy link

RPCS3.log.gz

@elad335 elad335 force-pushed the vm-overlay branch 2 times, most recently from 68a3424 to 896b7a1 Compare June 17, 2019 12:17
@elad335
Copy link
Contributor Author

elad335 commented Jun 17, 2019

Should be working now.

@kamer1337
Copy link

kamer1337 commented Jun 17, 2019 •
edited

same issue
RPCS3.log.gz

·F 0:00:04.247430 LDR: class std::runtime_error thrown: falloc() failed (addr=0x10070000, memsz=0x7b61d8) (in file c:\projects\rpcs3\rpcs3\emu\cell\ppumodule.cpp:1092)

@elad335
Copy link
Contributor Author

elad335 commented Jun 17, 2019

Retest.

@kamer1337
Copy link

its good now

@AniLeo AniLeo requested a review from Nekotekina June 18, 2019 21:48
@AniLeo
Copy link
Member

AniLeo commented Jul 3, 2019

Should be good, no review against

digitaldude555
digitaldude555 approved these changes Jul 3, 2019
View reviewed changes
Copy link

@digitaldude555 digitaldude555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good good

@elad335 elad335 changed the title [Review Requested] vm/sys_overlay Improvements vm/sys_overlay Improvements Jul 3, 2019
dio-gh
dio-gh approved these changes Jul 7, 2019
View reviewed changes
Copy link
Contributor

@dio-gh dio-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge/review please. @Nekotekina

@illusion0001
Copy link
Contributor

Looks good 👍
Let's wait for Neko to review/merge and we're good to go!

@elad335
Copy link
Contributor Author

elad335 commented Jul 8, 2019 •
edited

I would really like to hear what @Nekotekina thinks about it, if he requests to dig into the kernel much further I can.

@L1ttl3c0w
Copy link

@Nekotekina Could you please review this?

@elad335 elad335 force-pushed the vm-overlay branch 3 times, most recently from 815ea44 to 8448e40 Compare July 28, 2019 08:17
@elad335
Copy link
Contributor Author

elad335 commented Jul 28, 2019 •
edited

Due to new finding of ppc seg segment must be alocated at fixed 0x30000000 from sys_process_spawn reversing (source) and making this pull request extremely fast to review/merge due to known deadlines, I've removed .rsx_image, vm::main, and vm::user64k segments changes.

@elad335 elad335 force-pushed the vm-overlay branch 2 times, most recently from dffa63c to 2ef9ac0 Compare July 28, 2019 08:30
@elad335
vm/sys_overlay Improvements
22f6ba5 
- Implement sys_overlay_load_module_by_fd.
- Implement special segment allocation when ppc_seg flag is specified.
@Nekotekina Nekotekina merged commit 997e304 into RPCS3:master Jul 28, 2019
@elad335 elad335 deleted the vm-overlay branch July 28, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nekotekina Nekotekina Nekotekina left review comments

@fdemian fdemian fdemian approved these changes

@dio-gh dio-gh dio-gh approved these changes

@RainbowCookie32 RainbowCookie32 RainbowCookie32 approved these changes

@Luffykun007 Luffykun007 Luffykun007 approved these changes

@digitaldude555 digitaldude555 digitaldude555 approved these changes

@Parthorisian Parthorisian Parthorisian approved these changes

@illusion0001 illusion0001 illusion0001 approved these changes

Assignees
No one assigned
Labels
Bugfix Enhancement Firmware: HLE RSX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet